<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105731/">http://git.reviewboard.kde.org/r/105731/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 26th, 2012, 7:31 a.m., <b>Jos van den Oever</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Strigi has one version number for the collection of libraries. This version is available in strigiconfig.h which is often stored at /usr/include/strigi/strigiconfig.h
This version number applies to libstreams, libstreamanalyzer and the other libraries and executables.
#define STRIGI_VERSION_STRING "0.7.7"
#define STRIGI_VERSION_MAJOR 0
#define STRIGI_VERSION_MINOR 7
#define STRIGI_VERSION_RELEASE 7
</pre>
</blockquote>
<p>On July 26th, 2012, 7:36 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, but I'd like to know that information at runtime, not compile.
Right now, all the indexers do not conform to the ontologies, and some just crash. The files on which those indexers are used never get indexed, and each time Nepomuk restarts, the analyzers are run again. I rather only run the analyzers when the strigi version changes.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fair enough.
Some tips:
- do not use a new header, it's not needed, get the values from strigiconfig.h
- put the functions in Strigi:: namespace (there's more software with version numbers)
- put the functions in libstreams, not in libstreamanalyzer
Discussion point:
perhaps it's better to version the actual analyzers, but that's a large change
namespace Strigi {
unsigned int versionMajor();
unsigned int versionMinor();
unsigned int versionPatch();
const char* versionString();
}
</pre>
<br />
<p>- Jos</p>
<br />
<p>On July 25th, 2012, 4:05 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 25, 2012, 4:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This way applications can easily detect the current version of
libstreamanalyzer and change their behavior during runtime.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6387160)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(aa989ce)</span></li>
<li>lib/libstreamanalyzer_version.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libstreamanalyzer_version.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105731/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>