[Nepomuk] Review Request: Remove special handling for rdf:type

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105517/#review16122
-----------------------------------------------------------


This review has been submitted with commit 568a5e9dcafa62d99aa9444ee4a8884309285f54 by Vishesh Handa to branch testLibrary.

- Commit Hook


On July 15, 2012, 8:44 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105517/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 8:44 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Remove special handling for rdf:type
> 
> This includes storing the maintype when loading all the properties. This
> simplifies the code base, and actually improves performace.
> 
> Because the type deduction is done during load time, the relevant types
> needed to be loaded into memory by Types::EntityPrivate, this increases
> the load time for each resource by an order of 5x. This extra load
> eventually goes down when all the required types are loaded, but it's
> there.
> 
> Also, the additional cost of infering the type each time doesn't seem to
> have any performance loss. Mainly cause everything is already in memory.
> 
> Another reason for this patch is the planned refactoring of the class
> internals to use shared memory. Every extra variable in ResourceData
> adds an overhead.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resource.cpp c237f44 
>   libnepomukcore/resource/resourcedata.h 3708897 
>   libnepomukcore/resource/resourcedata.cpp 6fa262f 
> 
> Diff: http://git.reviewboard.kde.org/r/105517/diff/
> 
> 
> Testing
> -------
> 
> Manual + Unit Testing :)
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120719/e689e6ce/attachment.html>