[Nepomuk] Review Request: Fix race conditions in nepomuk's ResourceData.

David Faure faure at kde.org
Fri Jul 13 21:15:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105562/
-----------------------------------------------------------

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Description
-------

Fix race conditions in nepomuk's ResourceData.

Found with "helgrind kmail --nofork", inbox, clicking on any email.
where helgrind is "QT_NO_GLIB=1 valgrind --tool=helgrind --track-lockorders=no"

The change in resource.cpp avoids a deadlock due to the change
in resourcedata: no need to hold the rmMutex for the determineUri call.


Diffs
-----

  libnepomukcore/resource/resource.cpp c237f44c1420929143299aab391a0f2a7709f894 
  libnepomukcore/resource/resourcedata.cpp e19b4bdcd3bea11c32673d13df665cff24783e06 
  services/storage/datamanagementmodel.cpp 62882f88ab46b806f40f6a48f0d10972cc58fcb7 

Diff: http://git.reviewboard.kde.org/r/105562/diff/


Testing
-------


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120713/6e13cfce/attachment.html>


More information about the Nepomuk mailing list