[Nepomuk] Review Request: Allow synchronous execution of queries

Vishesh Handa me at vhanda.in
Wed Jul 11 15:38:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105287/
-----------------------------------------------------------

(Updated July 11, 2012, 3:38 p.m.)


Review request for Nepomuk.


Changes
-------

Removed the execute() function from Query::Query class.


Description
-------

Allow synchronous execution of queries

This is done by returning a Nepomuk::Query::ResultIterator, and
allows the user to control the execution of the query with the
iterator.

This lets us move away from Soprano. Plus, this avoids
code duplication as this code is being duplicated in both the
query service and the kioslave.


Diffs (updated)
-----

  includes/CMakeLists.txt 3e07f83 
  includes/Query/ResultIterator PRE-CREATION 
  libnepomukcore/CMakeLists.txt 066c898 
  libnepomukcore/query/resultiterator.h PRE-CREATION 
  libnepomukcore/query/resultiterator.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105287/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120711/5d19cbd4/attachment.html>


More information about the Nepomuk mailing list