[Nepomuk] Review Request: Allow synchronous execution of queries

[Vishesh Handa]

> On June 19, 2012, 4:46 a.m., Sebastian Trueg wrote:
> > libnepomukcore/query/resultiterator.h, line 32
> > <http://git.reviewboard.kde.org/r/105287/diff/1/?file=68203#file68203line32>
> >
> >     I think QueryIterator would be a better name.

Well, I thought it was a little bit too much - Query::QueryIterator. And it's iterating over a query's results, and not the actual query. Plus, that's the name we decided on during the Frameworks meetings.

http://community.kde.org/Projects/Nepomuk/Irc_meeting_nepomuk_frameworks#Queries


> On June 19, 2012, 4:46 a.m., Sebastian Trueg wrote:
> > libnepomukcore/query/resultiterator.h, line 35
> > <http://git.reviewboard.kde.org/r/105287/diff/1/?file=68203#file68203line35>
> >
> >     I think thanks to additionalBindings the reqpropmap is rather deprecated.

Well, I'm not sure, but I was under the impression that request properties now overshadowed the additional bindings. Is it the other way around? In either case, we should act fast cause we can break binary compatibility before 4.9 is released.


> On June 19, 2012, 4:46 a.m., Sebastian Trueg wrote:
> > libnepomukcore/query/query.h, line 573
> > <http://git.reviewboard.kde.org/r/105287/diff/1/?file=68201#file68201line573>
> >
> >     While I like the approach of calling execute directly on the query it does not match the design of the rest of the system. So far Query is a simple stand-alone container. To keep it that way it would be better to either have a method in the Nepomuk namespace or make the ResultIterator into something like:
> >     
> >     class QueryIterator {
> >     public:
> >     QueryIterator(const Query&);
> >     ...
> >     }

Will do.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105287/#review14872
-----------------------------------------------------------


On June 18, 2012, 12:47 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105287/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 12:47 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Allow synchronous execution of queries
> 
> This is done by returning a Nepomuk::Query::ResultIterator, and
> allows the user to control the execution of the query with the
> iterator.
> 
> This lets us move away from Soprano. Plus, this avoids
> code duplication as this code is being duplicated in both the
> query service and the kioslave.
> 
> 
> Diffs
> -----
> 
>   includes/Query/ResultIterator PRE-CREATION 
>   libnepomukcore/CMakeLists.txt 066c8986dfa2b3150072dbd96a71caf8873cea06 
>   libnepomukcore/query/query.h f4360b09fbc72bedcda5623e65d9e82359b66619 
>   libnepomukcore/query/query.cpp d67b6ce4cbbf5f30b468d9fd5b3399db1e3afd8c 
>   libnepomukcore/query/resultiterator.h PRE-CREATION 
>   libnepomukcore/query/resultiterator.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105287/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120711/eb277c92/attachment-0001.html>