[Nepomuk] Review Request: Do not reindex files on only WriteOnClose Events

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103794/
-----------------------------------------------------------

Review request for Nepomuk, Alex Fiestas and Sebastian Trueg.


Description
-------

This Filewatcher sends files for reindexing when it receives a WriteOnClose event from inotify. This event is generated whenever a file opened in write mode is closed. Even if they were no changes.

Programs like Amarok and KTorrent often open the files in write mode even when they don't make any changes. Which results in reindexing of those files.

For a graphical example - http://www.afiestas.org/nepomukReindexing.ogv


Diffs
-----

  nepomuk/services/filewatch/activefilequeue.h 19d4813 
  nepomuk/services/filewatch/activefilequeue.cpp 8bb54ed 
  nepomuk/services/filewatch/nepomukfilewatch.h cfb02fc 
  nepomuk/services/filewatch/nepomukfilewatch.cpp 60550c2 
  nepomuk/services/filewatch/test/activefilequeuetest.cpp 0445e8f 

Diff: http://git.reviewboard.kde.org/r/103794/diff/diff


Testing
-------

All the tests pass, and files are no longer reindexed when the song changes in Amarok.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120126/5cc71d11/attachment.html>