[Nepomuk] Review Request: PropertyChanged Signal in the Resource Watcher

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103522/#review9897
-----------------------------------------------------------

Ship it!


Great. Apart from the query patch part this looks good. Could you please port it over to nepomu-core, too.


nepomuk/services/queryservice/searchrunnable.cpp
<http://git.reviewboard.kde.org/r/103522/#comment8200>

    Is this part of the patch?


- Sebastian Trueg


On Jan. 17, 2012, 8:19 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103522/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 8:19 p.m.)
> 
> 
> Review request for Nepomuk, Martin Klapetek and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Implemented the propertyChanged signal in the Resource Watcher.
> 
> DBus is retarded. It refuses to work if I sent the changed list as a variant/variant list. It works if I send it as a string list though.
> 
> 
> Diffs
> -----
> 
>   nepomuk/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml 8b175bc 
>   nepomuk/services/queryservice/searchrunnable.cpp 9cc638a 
>   nepomuk/services/storage/datamanagementmodel.h 5825132 
>   nepomuk/services/storage/datamanagementmodel.cpp cab9a67 
>   nepomuk/services/storage/lib/resourcewatcher.h ac4425d 
>   nepomuk/services/storage/lib/resourcewatcher.cpp f6fc93c 
>   nepomuk/services/storage/resourcewatcherconnection.h 6100fb4 
>   nepomuk/services/storage/resourcewatchermanager.h 707ddab 
>   nepomuk/services/storage/resourcewatchermanager.cpp 6276254 
> 
> Diff: http://git.reviewboard.kde.org/r/103522/diff/diff
> 
> 
> Testing
> -------
> 
> Works perfectly. Tried monitoring NAO:numericRating
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120117/f3daab3e/attachment.html>