<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103522/">http://git.reviewboard.kde.org/r/103522/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great. Apart from the query patch part this looks good. Could you please port it over to nepomu-core, too.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103522/diff/2/?file=46899#file46899line90" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/services/queryservice/searchrunnable.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk::Query::SearchRunnable::run()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">while</span> <span class="p">(</span> <span class="n">m_folder</span> <span class="o">&&</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">while</span> <span class="p">(</span> <span class="n">m_folder</span> <span class="o">&&</span> <span class="n">hits</span><span class="p">.</span><span class="n">next</span><span class="p">()</span> <span class="o">&&</span> <span class="n">hits</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this part of the patch?</pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On January 17th, 2012, 8:19 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Martin Klapetek and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2012, 8:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented the propertyChanged signal in the Resource Watcher.
DBus is retarded. It refuses to work if I sent the changed list as a variant/variant list. It works if I send it as a string list though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works perfectly. Tried monitoring NAO:numericRating</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml <span style="color: grey">(8b175bc)</span></li>
<li>nepomuk/services/queryservice/searchrunnable.cpp <span style="color: grey">(9cc638a)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.h <span style="color: grey">(5825132)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.cpp <span style="color: grey">(cab9a67)</span></li>
<li>nepomuk/services/storage/lib/resourcewatcher.h <span style="color: grey">(ac4425d)</span></li>
<li>nepomuk/services/storage/lib/resourcewatcher.cpp <span style="color: grey">(f6fc93c)</span></li>
<li>nepomuk/services/storage/resourcewatcherconnection.h <span style="color: grey">(6100fb4)</span></li>
<li>nepomuk/services/storage/resourcewatchermanager.h <span style="color: grey">(707ddab)</span></li>
<li>nepomuk/services/storage/resourcewatchermanager.cpp <span style="color: grey">(6276254)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103522/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>