[Nepomuk] Review Request: FFmpegExtractor should index mp4 files, instead of TagLibExtractor

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107806/#review23783
-----------------------------------------------------------

Ship it!


I cannot really say. A lot of distros aren't going to ship the ffmpeg extractor. But then we shouldn't care about them.

Ideally, it would be awesome if there was some way to check if the ffmpeg extractor is not installed and then use taglib. Oh well. Ship it for now.

- Vishesh Handa


On Dec. 18, 2012, 11:18 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107806/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 11:18 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegExtractor, didn't see any specific reason why it should be indexed with TagLibExtractor and also it chokes with some of mp4 files.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/ffmpegextractor.cpp bf0d1d9 
>   services/fileindexer/indexer/taglibextractor.cpp 3b2d3cb 
> 
> Diff: http://git.reviewboard.kde.org/r/107806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121220/2e822ca9/attachment.html>