<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107806/">http://git.reviewboard.kde.org/r/107806/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot really say. A lot of distros aren't going to ship the ffmpeg extractor. But then we shouldn't care about them.
Ideally, it would be awesome if there was some way to check if the ffmpeg extractor is not installed and then use taglib. Oh well. Ship it for now.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On December 18th, 2012, 11:18 p.m., Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2012, 11:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegExtractor, didn't see any specific reason why it should be indexed with TagLibExtractor and also it chokes with some of mp4 files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/indexer/ffmpegextractor.cpp <span style="color: grey">(bf0d1d9)</span></li>
<li>services/fileindexer/indexer/taglibextractor.cpp <span style="color: grey">(3b2d3cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107806/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>