[Nepomuk] Review Request: FFmpegExtractor should index mp4 files, instead of TagLibExtractor

[Luis Silva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107806/#review23707
-----------------------------------------------------------



services/fileindexer/indexer/ffmpegextractor.cpp
<http://git.reviewboard.kde.org/r/107806/#comment18131>

    Shouldn't this be "video/mp4" instead?


- Luis Silva


On Dec. 18, 2012, 8:54 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107806/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 8:54 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegExtractor, didn't see any specific reason why it should be indexed with TagLibExtractor and also it chokes with some of mp4 files.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/ffmpegextractor.cpp bf0d1d9 
>   services/fileindexer/indexer/taglibextractor.cpp 3b2d3cb 
> 
> Diff: http://git.reviewboard.kde.org/r/107806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121218/d98e5303/attachment-0001.html>