[Nepomuk] Review Request: FFmpegExtractor should index mp4 files, instead of TagLibExtractor

Hrvoje Senjan hrvoje.senjan at gmail.com
Tue Dec 18 23:17:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107806/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 11:17 p.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

Thanks for notice Luis :-) Fixed now


Description
-------

Super-trivial fix, swap video/mp4 filetype from TagLibExtractor to FFmpegExtractor, didn't see any specific reason why it should be indexed with TagLibExtractor and also it chokes with some of mp4 files.


Diffs (updated)
-----

  services/fileindexer/indexer/ffmpegextractor.cpp bf0d1d9 
  services/fileindexer/indexer/taglibextractor.cpp 3b2d3cb 

Diff: http://git.reviewboard.kde.org/r/107806/diff/


Testing
-------


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121218/d9d8f580/attachment.html>


More information about the Nepomuk mailing list