[Nepomuk] Review Request: when resume index, recheck if there is anything available for file indexing queue

[Xuetian Weng]

> On Dec. 16, 2012, 6:02 p.m., Vishesh Handa wrote:
> > You have forgotten to enable the disk space monitor. Also, if you want you can remove the enable/disable functions entirely. They now serve no purpose.

well.. actually I didn't forgot. "enable()" itself still cover the startup for disk space monitor.

and enable() / disable() is used when user suspend it manually (see IndexScheduler::suspend and IndexScheduler::resume). In that case
1. enable will enable both idle time and disk space monitor
2. disable will disable both too.
3. suspendDiskSpaceMonitor will stop disk space monitor
4. resumeDiskSpaceMonitor will start monitor IF EventMonitor is enabled.

If user suspend the index manually, the idleTime should be disabled too.

Hope that's make this patch more clear.

resumeDiskSpaceMonitor is not used on purpose, I just leave it there... in case some one need it.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107760/#review23553
-----------------------------------------------------------


On Dec. 16, 2012, 4:54 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107760/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 4:54 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> I'm trying to figure out the nepomuk index problem for 4.10. Since after I upgrade.. it works quite differently. Since two level index is introduced.
> 
> After read through the code, I found that simple queue would have no/less problem, but file indexing queue case is much more different.
> Seems there is no way to notify file indexing queue that some new data is needed to be indexed. So nepomuk cold start will not index any file content, since initially queue is empty.
> 
> My proposal is like this:
> When PC enter the idle state, FileIndexing->resume will be called, currently, it will check the queue empty or not, so if it's empty, it will never be re-filled, which is quite bad.
> 
> So now we can always let pc using idle to recheck the state. Which is not very perfect, but it's practical.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexingqueue.cpp 1bda660 
>   services/fileindexer/eventmonitor.h 677292c 
>   services/fileindexer/eventmonitor.cpp f188645 
>   services/fileindexer/fileindexingqueue.h 11b577a 
>   services/fileindexer/indexingqueue.h d51559f 
>   services/fileindexer/indexingqueue.cpp ff48fa2 
>   services/fileindexer/indexscheduler.cpp 0c56329 
> 
> Diff: http://git.reviewboard.kde.org/r/107760/diff/
> 
> 
> Testing
> -------
> 
> Compiles, work as it suppose to be.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121216/a3d2aecd/attachment-0001.html>