<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107760/">http://git.reviewboard.kde.org/r/107760/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2012, 6:02 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have forgotten to enable the disk space monitor. Also, if you want you can remove the enable/disable functions entirely. They now serve no purpose.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well.. actually I didn't forgot. "enable()" itself still cover the startup for disk space monitor.
and enable() / disable() is used when user suspend it manually (see IndexScheduler::suspend and IndexScheduler::resume). In that case
1. enable will enable both idle time and disk space monitor
2. disable will disable both too.
3. suspendDiskSpaceMonitor will stop disk space monitor
4. resumeDiskSpaceMonitor will start monitor IF EventMonitor is enabled.
If user suspend the index manually, the idleTime should be disabled too.
Hope that's make this patch more clear.
resumeDiskSpaceMonitor is not used on purpose, I just leave it there... in case some one need it.</pre>
<br />
<p>- Xuetian</p>
<br />
<p>On December 16th, 2012, 4:54 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm trying to figure out the nepomuk index problem for 4.10. Since after I upgrade.. it works quite differently. Since two level index is introduced.
After read through the code, I found that simple queue would have no/less problem, but file indexing queue case is much more different.
Seems there is no way to notify file indexing queue that some new data is needed to be indexed. So nepomuk cold start will not index any file content, since initially queue is empty.
My proposal is like this:
When PC enter the idle state, FileIndexing->resume will be called, currently, it will check the queue empty or not, so if it's empty, it will never be re-filled, which is quite bad.
So now we can always let pc using idle to recheck the state. Which is not very perfect, but it's practical.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, work as it suppose to be.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexingqueue.cpp <span style="color: grey">(1bda660)</span></li>
<li>services/fileindexer/eventmonitor.h <span style="color: grey">(677292c)</span></li>
<li>services/fileindexer/eventmonitor.cpp <span style="color: grey">(f188645)</span></li>
<li>services/fileindexer/fileindexingqueue.h <span style="color: grey">(11b577a)</span></li>
<li>services/fileindexer/indexingqueue.h <span style="color: grey">(d51559f)</span></li>
<li>services/fileindexer/indexingqueue.cpp <span style="color: grey">(ff48fa2)</span></li>
<li>services/fileindexer/indexscheduler.cpp <span style="color: grey">(0c56329)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107760/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>