[Nepomuk] Review Request: when resume index, recheck if there is anything available for file indexing queue

[Xuetian Weng]

> On Dec. 16, 2012, 4:22 p.m., Vishesh Handa wrote:
> > services/fileindexer/indexscheduler.cpp, line 202
> > <http://git.reviewboard.kde.org/r/107760/diff/2/?file=99839#file99839line202>
> >
> >     With this the EventMonitor will never be disabled. One should disable the event monitor when it is no longer required cause it has a timer which checks for free disk space every 60 seconds or so.
> >     
> >     Maybe we could rename the EventMonitor suspend/resume to suspentDiskSpaceMonitor, and only pause that?
> >     
> >     I'm not sure.

Is disk space checking a very cost operation? If not.. we can just leave it there.
Or just like what you said, add a new function to monitor (since disable() itself is still useful), just to disable the disk monitor. If no index is working monitor disk space is kinds of pointless.

BTW Event monitor will be disabled if user suspend index manually.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107760/#review23546
-----------------------------------------------------------


On Dec. 16, 2012, 3:56 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107760/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 3:56 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> I'm trying to figure out the nepomuk index problem for 4.10. Since after I upgrade.. it works quite differently. Since two level index is introduced.
> 
> After read through the code, I found that simple queue would have no/less problem, but file indexing queue case is much more different.
> Seems there is no way to notify file indexing queue that some new data is needed to be indexed. So nepomuk cold start will not index any file content, since initially queue is empty.
> 
> My proposal is like this:
> When PC enter the idle state, FileIndexing->resume will be called, currently, it will check the queue empty or not, so if it's empty, it will never be re-filled, which is quite bad.
> 
> So now we can always let pc using idle to recheck the state. Which is not very perfect, but it's practical.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexingqueue.h 11b577a 
>   services/fileindexer/fileindexingqueue.cpp 1bda660 
>   services/fileindexer/indexingqueue.h d51559f 
>   services/fileindexer/indexingqueue.cpp ff48fa2 
>   services/fileindexer/indexscheduler.cpp 0c56329 
> 
> Diff: http://git.reviewboard.kde.org/r/107760/diff/
> 
> 
> Testing
> -------
> 
> Compiles, work as it suppose to be.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121216/849ce122/attachment.html>