<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107760/">http://git.reviewboard.kde.org/r/107760/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2012, 4:22 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107760/diff/2/?file=99839#file99839line202" style="color: black; font-weight: bold; text-decoration: underline;">services/fileindexer/indexscheduler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk2::IndexScheduler::slotStartedIndexing()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">202</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_eventMonitor</span><span class="o">-></span><span class="n">disable</span><span class="p">();</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this the EventMonitor will never be disabled. One should disable the event monitor when it is no longer required cause it has a timer which checks for free disk space every 60 seconds or so.
Maybe we could rename the EventMonitor suspend/resume to suspentDiskSpaceMonitor, and only pause that?
I'm not sure.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is disk space checking a very cost operation? If not.. we can just leave it there.
Or just like what you said, add a new function to monitor (since disable() itself is still useful), just to disable the disk monitor. If no index is working monitor disk space is kinds of pointless.
BTW Event monitor will be disabled if user suspend index manually.</pre>
<br />
<p>- Xuetian</p>
<br />
<p>On December 16th, 2012, 3:56 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2012, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm trying to figure out the nepomuk index problem for 4.10. Since after I upgrade.. it works quite differently. Since two level index is introduced.
After read through the code, I found that simple queue would have no/less problem, but file indexing queue case is much more different.
Seems there is no way to notify file indexing queue that some new data is needed to be indexed. So nepomuk cold start will not index any file content, since initially queue is empty.
My proposal is like this:
When PC enter the idle state, FileIndexing->resume will be called, currently, it will check the queue empty or not, so if it's empty, it will never be re-filled, which is quite bad.
So now we can always let pc using idle to recheck the state. Which is not very perfect, but it's practical.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, work as it suppose to be.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexingqueue.h <span style="color: grey">(11b577a)</span></li>
<li>services/fileindexer/fileindexingqueue.cpp <span style="color: grey">(1bda660)</span></li>
<li>services/fileindexer/indexingqueue.h <span style="color: grey">(d51559f)</span></li>
<li>services/fileindexer/indexingqueue.cpp <span style="color: grey">(ff48fa2)</span></li>
<li>services/fileindexer/indexscheduler.cpp <span style="color: grey">(0c56329)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107760/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>