[Nepomuk] Review Request: nepomuk file indexer will fork more than one nepomukindexer at the same time

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107756/#review23536
-----------------------------------------------------------

Ship it!


I love it when people fix bugs that have been bugging me. Thanks a lot. I've been meaning to figure out why this was happening.

Was the code easy to understand?

- Vishesh Handa


On Dec. 16, 2012, 2:04 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107756/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 2:04 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Possible call sequence. processNextIteration call process, queue is empty, then trigger finishIteration. But "process" itself will also trigger finishIteration in the future when KJob finished. Two finishIteration call will cause there might more than one nepomukindexer running, and it will fork more and more.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexingqueue.cpp aeb5da1 
>   services/fileindexer/indexingqueue.cpp bc27734 
> 
> Diff: http://git.reviewboard.kde.org/r/107756/diff/
> 
> 
> Testing
> -------
> 
> Compiles, seems fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121216/2fe109c5/attachment.html>