[Nepomuk] Review Request: nepomuk file indexer will fork more than one nepomukindexer at the same time

Xuetian Weng wengxt at gmail.com
Sun Dec 16 14:04:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107756/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

Possible call sequence. processNextIteration call process, queue is empty, then trigger finishIteration. But "process" itself will also trigger finishIteration in the future when KJob finished. Two finishIteration call will cause there might more than one nepomukindexer running, and it will fork more and more.


Diffs
-----

  services/fileindexer/fileindexingqueue.cpp aeb5da1 
  services/fileindexer/indexingqueue.cpp bc27734 

Diff: http://git.reviewboard.kde.org/r/107756/diff/


Testing
-------

Compiles, seems fixed.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121216/6fd0191a/attachment.html>


More information about the Nepomuk mailing list