[Nepomuk] Review Request: NepomukSearch: Fetch the mimetype from the database

[Sebastian Trueg]

> On Aug. 29, 2012, 1:19 p.m., Sebastian Trueg wrote:
> > nepomuk/kioslaves/search/searchfolder.cpp, line 185
> > <http://git.reviewboard.kde.org/r/106264/diff/1/?file=82221#file82221line185>
> >
> >     I am a bit confused now. Originally on Unix the kio slave would add a bunch of request vars to the query to get things like the mime type. Now I cannot seem to find that code anymore. Because I think a request var is the better solution here. mimetype can also be fetched on non-unix systems.

OK, answering myself: the code is still there in queryutil.h. So IMHO just add the mimetype thing always, also on non-unix systems. That way you can always extract it from the query result if it is stored.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106264/#review18238
-----------------------------------------------------------


On Aug. 29, 2012, 12:53 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106264/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 12:53 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Instead of determining it based on the file url. We already know the
>     mimetype after we index the file.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kioslaves/search/searchfolder.cpp 96d1899 
> 
> Diff: http://git.reviewboard.kde.org/r/106264/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/91567be1/attachment.html>