[Nepomuk] Review Request: NepomukSearch: Fetch the mimetype from the database
Sebastian Trueg
sebastian at trueg.de
Wed Aug 29 13:19:31 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106264/#review18238
-----------------------------------------------------------
nepomuk/kioslaves/search/searchfolder.cpp
<http://git.reviewboard.kde.org/r/106264/#comment14433>
I am a bit confused now. Originally on Unix the kio slave would add a bunch of request vars to the query to get things like the mime type. Now I cannot seem to find that code anymore. Because I think a request var is the better solution here. mimetype can also be fetched on non-unix systems.
- Sebastian Trueg
On Aug. 29, 2012, 12:53 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106264/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2012, 12:53 p.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Description
> -------
>
> Instead of determining it based on the file url. We already know the
> mimetype after we index the file.
>
>
> Diffs
> -----
>
> nepomuk/kioslaves/search/searchfolder.cpp 96d1899
>
> Diff: http://git.reviewboard.kde.org/r/106264/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/73849612/attachment.html>
More information about the Nepomuk
mailing list