[Nepomuk] Review Request: FileIndexer: Do not check for new files on startup

[Sebastian Trueg]

> On Aug. 29, 2012, 9:49 a.m., Sebastian Trueg wrote:
> > In principal this is a good idea but IMHO should be combined with actual re-indexing with new indexer versions (strigi-plugin-based). After all files will not be reindexed even if there is a new or better indexer plugin available.
> > Also we still have the problem of files that changed or appeared in between Nepomuk runs.
> 
> Vishesh Handa wrote:
>     We can't please everyone. If someone chooses not to run Nepomuk all the time, then some of their files don't get indexed. With 4.10, I think we can add an option for manually triggering checking of new files, but for now it makes sense to optimize for the general case.
>     
>     Eventually, yes, we'll have to move to a plugin based versioning system, but for now my main concern is not the re-indexing, it's all those files which never get indexed (faulty indexers) and just re-indexed on startup every single time. It's unnecessary CPU usage. Plus, it leads to bad press and people think Nepomuk has never finished indexing the files.

If there are many of those files, fine.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106256/#review18215
-----------------------------------------------------------


On Aug. 28, 2012, 6:09 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106256/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 6:09 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Only check for changes if the strigi version changes, cause in that case
>     their may be a new plugin or an earlier plugin may have been fixed.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/CMakeLists.txt f9eea59 
>   services/fileindexer/fileindexer.cpp af8be4d 
>   services/fileindexer/fileindexerconfig.h 1113220 
>   services/fileindexer/fileindexerconfig.cpp 2ca973c 
> 
> Diff: http://git.reviewboard.kde.org/r/106256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120829/a956c005/attachment.html>