<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106256/">http://git.reviewboard.kde.org/r/106256/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 29th, 2012, 9:49 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In principal this is a good idea but IMHO should be combined with actual re-indexing with new indexer versions (strigi-plugin-based). After all files will not be reindexed even if there is a new or better indexer plugin available.
Also we still have the problem of files that changed or appeared in between Nepomuk runs.</pre>
</blockquote>
<p>On August 29th, 2012, 10:05 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We can't please everyone. If someone chooses not to run Nepomuk all the time, then some of their files don't get indexed. With 4.10, I think we can add an option for manually triggering checking of new files, but for now it makes sense to optimize for the general case.
Eventually, yes, we'll have to move to a plugin based versioning system, but for now my main concern is not the re-indexing, it's all those files which never get indexed (faulty indexers) and just re-indexed on startup every single time. It's unnecessary CPU usage. Plus, it leads to bad press and people think Nepomuk has never finished indexing the files.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there are many of those files, fine.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On August 28th, 2012, 6:09 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2012, 6:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Only check for changes if the strigi version changes, cause in that case
their may be a new plugin or an earlier plugin may have been fixed.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/CMakeLists.txt <span style="color: grey">(f9eea59)</span></li>
<li>services/fileindexer/fileindexer.cpp <span style="color: grey">(af8be4d)</span></li>
<li>services/fileindexer/fileindexerconfig.h <span style="color: grey">(1113220)</span></li>
<li>services/fileindexer/fileindexerconfig.cpp <span style="color: grey">(2ca973c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106256/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>