[Nepomuk] Review Request: Not invoking the nepomukindex process for every file, just when it exits

Ivan Čukić ivan.cukic at kde.org
Wed Apr 18 15:41:05 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104661/#review12632
-----------------------------------------------------------


- Ivan Čukić


On April 18, 2012, 3:40 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104661/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 3:40 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> This patch:
> - nepomukindexer: adds "--stdin" option to nepomukindexer. It gets the files from the standard input, and indexes them. For each indexed file, it reports the status via stdout.
> - nepomukfileindexer service starts the nepomukindexer only if not already running, and passes the files to index via the processe's stdin. If the process exits for some reason (crash...), and a new file needs indexing, it is restarted.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/fileindexer/indexer/main.cpp 72d373a 
>   nepomuk/services/fileindexer/nepomukindexer.h 3188eef 
>   nepomuk/services/fileindexer/nepomukindexer.cpp c063e70 
> 
> Diff: http://git.reviewboard.kde.org/r/104661/diff/
> 
> 
> Testing
> -------
> 
> Been testing for a few hours.
> 
> But it needs to be tested by others as well. Especially to reproduce crashes in the indexer since it didn't crash for me.
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120418/b2194b35/attachment.html>


More information about the Nepomuk mailing list