[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon

[François K.]

----- "Martin Klapetek" <martin.klapetek at gmail.com> a écrit :

> De: "Martin Klapetek" <martin.klapetek at gmail.com>
> À: "Martin Klapetek" <martin.klapetek at gmail.com>, "Smit Shah" <who828 at gmail.com>, "François Kubler"
> <francois at kubler.org>, "Nepomuk" <nepomuk at kde.org>
> Envoyé: Jeudi 29 Septembre 2011 09h47:09 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne
> Objet: Re: [Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon
>
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102726/
> 
> 
> 
> 
> On September 28th, 2011, 9:52 p.m., François Kubler wrote:
> 
> 
> nepomuk/controller/systray.cpp (Diff revision 2)
> 	Nepomuk::SystemTray::SystemTray( QObject* parent )
> 	112 	m_updateTimer . start ( 5000 ); When started like that, the
> timeout SIGNAL will be fired every 5 seconds. I don't think this is
> needed, is it ?
> Shouldn't the SIGNAL be fired only once to tell the widget to blink ?
> (if so, you could use something like setSingleShot(true) ). There's
> also a static method for that -- QTimer::singleShot()
> 
> 
> - Martin


Yes, but the static method can't be cancelled (for example, if indexing is stopped after 2 seconds), can it ?
I'm really new to Qt, so you'd better check what I say twice :)

Have a nice day,

-- 
François


> 
> 
> On September 28th, 2011, 6:22 p.m., Smit Shah wrote:
> Review request for Nepomuk.
> By Smit Shah.
> 
> Updated Sept. 28, 2011, 6:22 p.m. Description
> 	Now that i have added a timer it should fix the rapid passive/active
> changes in nepomuk system tray icon.
> Bugs: Active/Non , active , controller , of , state Diffs
> 
> 
>     • nepomuk/controller/systray.h (06261b7)
>     • nepomuk/controller/systray.cpp (b67eb6c)
> 
> 
> View Diff 
> _______________________________________________
> Nepomuk mailing list
> Nepomuk at kde.org
> https://mail.kde.org/mailman/listinfo/nepomuk