[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon

[Martin Klapetek]

> On Sept. 28, 2011, 9:52 p.m., François Kubler wrote:
> > nepomuk/controller/systray.cpp, line 113
> > <http://git.reviewboard.kde.org/r/102726/diff/2/?file=37411#file37411line113>
> >
> >     When started like that, the timeout SIGNAL will be fired every 5 seconds. I don't think this is needed, is it ?
> >     Shouldn't the SIGNAL be fired only once to tell the widget to blink ? (if so, you could use something like setSingleShot(true) ).

There's also a static method for that -- QTimer::singleShot()


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102726/#review6894
-----------------------------------------------------------


On Sept. 28, 2011, 6:22 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102726/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.
> 
> 
> This addresses bugs Active/Non, active, controller, of, and state.
>     http://bugs.kde.org/show_bug.cgi?id=Active/Non
>     http://bugs.kde.org/show_bug.cgi?id=active
>     http://bugs.kde.org/show_bug.cgi?id=controller
>     http://bugs.kde.org/show_bug.cgi?id=of
>     http://bugs.kde.org/show_bug.cgi?id=state
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.h 06261b7 
>   nepomuk/controller/systray.cpp b67eb6c 
> 
> Diff: http://git.reviewboard.kde.org/r/102726/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110929/effb38a6/attachment.html>