[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon

[Sebastian Trueg]

> On Oct. 1, 2011, 8:52 a.m., Sebastian Trueg wrote:
> > You state that you tested it. However, if it worked, then only by accident, ie. because the status changed signal is also emitted if the indexer starts on another file.

Let me elaborate: imagine the indexer starts indexing a very large file. And imagine indexing of this file takes 10 minutes (unrealistic but necessary to prove my point). Then the indexer service will emit the statusChanged() signal once at the beginning of the indexing. You start the timer and 3 seconds later set m_newStatus to Active. Then nothing happens until the service finished 10 minutes later. The systray icon did never change its status!


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102726/#review6924
-----------------------------------------------------------


On Sept. 29, 2011, 7:29 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102726/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 7:29 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.
> 
> 
> This addresses bugs Active/Non, active, controller, of, and state.
>     http://bugs.kde.org/show_bug.cgi?id=Active/Non
>     http://bugs.kde.org/show_bug.cgi?id=active
>     http://bugs.kde.org/show_bug.cgi?id=controller
>     http://bugs.kde.org/show_bug.cgi?id=of
>     http://bugs.kde.org/show_bug.cgi?id=state
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.h 06261b7 
>   nepomuk/controller/systray.cpp b67eb6c 
> 
> Diff: http://git.reviewboard.kde.org/r/102726/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20111001/3662c00d/attachment.html>