<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102726/">http://git.reviewboard.kde.org/r/102726/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 1st, 2011, 8:52 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You state that you tested it. However, if it worked, then only by accident, ie. because the status changed signal is also emitted if the indexer starts on another file.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me elaborate: imagine the indexer starts indexing a very large file. And imagine indexing of this file takes 10 minutes (unrealistic but necessary to prove my point). Then the indexer service will emit the statusChanged() signal once at the beginning of the indexing. You start the timer and 3 seconds later set m_newStatus to Active. Then nothing happens until the service finished 10 minutes later. The systray icon did never change its status!</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 29th, 2011, 7:29 p.m., Smit Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Smit Shah.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2011, 7:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=Active/Non">Active/Non</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=active">active</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=controller">controller</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=of">of</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=state">state</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/controller/systray.h <span style="color: grey">(06261b7)</span></li>
<li>nepomuk/controller/systray.cpp <span style="color: grey">(b67eb6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102726/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>