[Nepomuk] Review Request: Correct handle of "disc number" tag in mp3 files

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102994/#review7907
-----------------------------------------------------------


This review has been submitted with commit 0ddc215b15dc1fe91e6e50e4b54b535bc13fd935 by Sebastian Trueg to branch master.

- Commit Hook


On Oct. 30, 2011, 10:43 a.m., Ignacio Serantes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102994/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2011, 10:43 a.m.)
> 
> 
> Review request for Nepomuk and Strigi.
> 
> 
> Description
> -------
> 
> This patch solves a bug that prevented mp3 files with "disc number" tag being indexed. Code is based in "track number" code, and in the solution implemented in "flacendanalyzer.cpp", with the exception of the "found_track" flag because I think that is not necessary.
> 
> The error message displayed by nepomukserver was:
> Soprano: "Invalid argument (1)": "<http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#setNumber> has a rdfs:domain of <http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#MusicPiece>. <_:c> only has the following types <http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#MusicAlbum>, <http://www.w3.org/2000/01/rdf-schema#Resource>"
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/id3endanalyzer.h 4d33740 
>   lib/endanalyzers/id3endanalyzer.cpp a3b33ae 
> 
> Diff: http://git.reviewboard.kde.org/r/102994/diff/diff
> 
> 
> Testing
> -------
> 
> Before applying the patch:
> -Trying to index several mp3s with disc number tag: indexing fails
> -Trying to index the same mp3s after disc number tag was removed: indexing works
> 
> After applying the patch:
> -Trying to index several mp3s with disc number tag: indexing worked and proper value was set in nmm:setNumber
> 
> 
> Thanks,
> 
> Ignacio Serantes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20111103/65a24ed9/attachment.html>