[Nepomuk] Re: Load/Save queries

[Who Knows]

 Okay i have fixed whatever you had asked , again tell if i missed anything.

- Smit Shah

On Wed, Mar 23, 2011 at 12:48 AM, Sebastian Trüg <trueg at kde.org> wrote:

> I have only two tiny comments left:
>
> On 03/22/2011 05:42 PM, Who Knows wrote:
> > +    m_resourceQueryWidget->openQuery();;
>
> duplicate semicolon
>
> >  <?xml version="1.0" encoding="UTF-8"?>
> >  <gui name="nepomukshell"
> > -     version="3"
> > +     version="3.1"
>
> AFAIK we can only use integers here which means it would have to be "4".
> I am not sure though.
>
> > +    QString fileName =  KFileDialog::getOpenFileName(KUrl(),
> QString("*.txt"), this, i18n( "Open a query to edit" ));
>
> Just as a hint: It is recommended to use QLatin1String("*.txt") since
> that avoids loading a text codec in Qt. But that is a detail mostly for
> your benefit. :)
>
> Great work. I will commit this tomorrow.
>
> Cheers,
> Sebastian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110323/45339278/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 4904 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20110323/45339278/attachment.diff