Okay i have fixed whatever you had asked , again tell if i missed anything.<br> <br>- Smit Shah<br><br><div class="gmail_quote">On Wed, Mar 23, 2011 at 12:48 AM, Sebastian Trüg <span dir="ltr"><<a href="mailto:trueg@kde.org">trueg@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I have only two tiny comments left:<br>
<br>
On 03/22/2011 05:42 PM, Who Knows wrote:<br>
> + m_resourceQueryWidget->openQuery();;<br>
<br>
duplicate semicolon<br>
<br>
> <?xml version="1.0" encoding="UTF-8"?><br>
> <gui name="nepomukshell"<br>
> - version="3"<br>
> + version="3.1"<br>
<br>
AFAIK we can only use integers here which means it would have to be "4".<br>
I am not sure though.<br>
<br>
> + QString fileName = KFileDialog::getOpenFileName(KUrl(), QString("*.txt"), this, i18n( "Open a query to edit" ));<br>
<br>
Just as a hint: It is recommended to use QLatin1String("*.txt") since<br>
that avoids loading a text codec in Qt. But that is a detail mostly for<br>
your benefit. :)<br>
<br>
Great work. I will commit this tomorrow.<br>
<br>
Cheers,<br>
<font color="#888888">Sebastian<br>
</font></blockquote></div><br>