[Nepomuk] Re: Review Request: Merge nepomuk system tray into kde-runtime

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101786/#review4191
-----------------------------------------------------------


I will have to review this project in general as I did a while back before looking at the code:
The user is not really concerned with the status of any Nepomuk services since that is an implementation detail. Thus, your main widget is not very end user friendly. It could be a great developer tool though if it also provided the possibility to start and stop services.

The there are a few issues:
- The tooltip just shows "Running Running Running Running Running" without any details
- The menu has two quit actions
- The systray applet does not provide actions to suspend/resume strigi or show its detailed status.
- I have two entries for the strigi service here

Also I see no need for a plugin system when there is only one single plugin.

So for now I would have to vote against this merge as it does not bring any useful features to the user while at the same time removing essential ones.

- Sebastian


On June 27, 2011, 8:13 a.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101786/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 8:13 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Merge project nepomuk-system-tray into kde-runtime.
> 
> (Quick note: There were a merge request about 6-8 month ago, it was done in bug tracker and I think it is long gone )
> 
> Description of the project: provides library and several runtime components ( well, currently one, plasma dataengine is in [slow] development ) for quering and displaying status(es) of nepomuk service(s).
> 
> 2 main parts + plugins:
> library - view independed, async, plugin-based framework that allow you to track status of the service
> runtime/[systemtray] - current implementation of system tray, done with usual technologies ( no plasma/QML )
> plugins/ - library with written plugin for strigi and build-time plugin autogeneration for other services.
> 
> Personal repo is git at git.kde.org:nepomuk-system-tray
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/CMakeLists.txt 76c452d 
>   nepomuk/controller/Messages.sh ea4aa1e 
>   nepomuk/controller/lib/CMakeLists.txt PRE-CREATION 
>   nepomuk/controller/lib/config.h.in PRE-CREATION 
>   nepomuk/controller/lib/nepomuksystray_export.h PRE-CREATION 
>   nepomuk/controller/lib/serverclient.h PRE-CREATION 
>   nepomuk/controller/lib/systrayplugin.h PRE-CREATION 
>   nepomuk/controller/lib/systrayplugin.cpp PRE-CREATION 
>   nepomuk/controller/lib/systraypluginmanager.h PRE-CREATION 
>   nepomuk/controller/lib/systraypluginmanager.cpp PRE-CREATION 
>   nepomuk/controller/main.cpp c14c165 
>   nepomuk/controller/nepomukcontroller.desktop debbfff 
>   nepomuk/controller/plugins/CMakeLists.txt PRE-CREATION 
>   nepomuk/controller/plugins/basic_template/nepomuksystray_template.desktop.in PRE-CREATION 
>   nepomuk/controller/plugins/basic_template/systraytemplatepluginui.rc.in PRE-CREATION 
>   nepomuk/controller/plugins/basic_template/templateplugin.cpp.in PRE-CREATION 
>   nepomuk/controller/plugins/basic_template/templateplugin.h.in PRE-CREATION 
>   nepomuk/controller/plugins/nepomuksystray_plugin.desktop PRE-CREATION 
>   nepomuk/controller/plugins/strigi/CMakeLists.txt PRE-CREATION 
>   nepomuk/controller/plugins/strigi/nepomuksystray_strigi.desktop PRE-CREATION 
>   nepomuk/controller/plugins/strigi/strigiplugin.h PRE-CREATION 
>   nepomuk/controller/plugins/strigi/strigiplugin.cpp PRE-CREATION 
>   nepomuk/controller/plugins/strigi/systraystrigipluginui.rc PRE-CREATION 
>   nepomuk/controller/runtime/CMakeLists.txt PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/CMakeLists.txt PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/main.cpp PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/mainWidget.ui PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/mainWindow.ui PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/mainwidget.h PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/mainwidget.cpp PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/nepomukcontroller.desktop PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/nepomukcontrollerrc PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/nepomukcontrollerui.rc PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/serviceWidget.ui PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/servicewidget.h PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/servicewidget.cpp PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/systray.h PRE-CREATION 
>   nepomuk/controller/runtime/systemtray/systray.cpp PRE-CREATION 
>   nepomuk/controller/systray.h 3e2adb6 
>   nepomuk/controller/systray.cpp 920877b 
> 
> Diff: http://git.reviewboard.kde.org/r/101786/diff
> 
> 
> Testing
> -------
> 
> Testing:
> ( My machine ) GNU/Linux x86_64, 2.6.38.
> 
> Compiles, works. There are problems with resizing of main widget - Qt doesn't support automatic resizing of top-level windows, so a dirty-dirty hack is used.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110627/12011563/attachment-0001.htm