<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101786/">http://git.reviewboard.kde.org/r/101786/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will have to review this project in general as I did a while back before looking at the code:
The user is not really concerned with the status of any Nepomuk services since that is an implementation detail. Thus, your main widget is not very end user friendly. It could be a great developer tool though if it also provided the possibility to start and stop services.
The there are a few issues:
- The tooltip just shows "Running Running Running Running Running" without any details
- The menu has two quit actions
- The systray applet does not provide actions to suspend/resume strigi or show its detailed status.
- I have two entries for the strigi service here
Also I see no need for a plugin system when there is only one single plugin.
So for now I would have to vote against this merge as it does not bring any useful features to the user while at the same time removing essential ones.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 27th, 2011, 8:13 a.m., Artem Serebriyskiy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Artem Serebriyskiy.</div>
<p style="color: grey;"><i>Updated June 27, 2011, 8:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Merge project nepomuk-system-tray into kde-runtime.
(Quick note: There were a merge request about 6-8 month ago, it was done in bug tracker and I think it is long gone )
Description of the project: provides library and several runtime components ( well, currently one, plasma dataengine is in [slow] development ) for quering and displaying status(es) of nepomuk service(s).
2 main parts + plugins:
library - view independed, async, plugin-based framework that allow you to track status of the service
runtime/[systemtray] - current implementation of system tray, done with usual technologies ( no plasma/QML )
plugins/ - library with written plugin for strigi and build-time plugin autogeneration for other services.
Personal repo is git@git.kde.org:nepomuk-system-tray</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing:
( My machine ) GNU/Linux x86_64, 2.6.38.
Compiles, works. There are problems with resizing of main widget - Qt doesn't support automatic resizing of top-level windows, so a dirty-dirty hack is used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/controller/CMakeLists.txt <span style="color: grey">(76c452d)</span></li>
<li>nepomuk/controller/Messages.sh <span style="color: grey">(ea4aa1e)</span></li>
<li>nepomuk/controller/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/config.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/nepomuksystray_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/serverclient.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/systrayplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/systrayplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/systraypluginmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/lib/systraypluginmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/main.cpp <span style="color: grey">(c14c165)</span></li>
<li>nepomuk/controller/nepomukcontroller.desktop <span style="color: grey">(debbfff)</span></li>
<li>nepomuk/controller/plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/basic_template/nepomuksystray_template.desktop.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/basic_template/systraytemplatepluginui.rc.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/basic_template/templateplugin.cpp.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/basic_template/templateplugin.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/nepomuksystray_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/strigi/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/strigi/nepomuksystray_strigi.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/strigi/strigiplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/strigi/strigiplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/plugins/strigi/systraystrigipluginui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/mainWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/mainWindow.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/mainwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/mainwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/nepomukcontroller.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/nepomukcontrollerrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/nepomukcontrollerui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/serviceWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/servicewidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/servicewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/systray.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/runtime/systemtray/systray.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/controller/systray.h <span style="color: grey">(3e2adb6)</span></li>
<li>nepomuk/controller/systray.cpp <span style="color: grey">(920877b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101786/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>