[Nepomuk] Re: Review Request: Port raptor serializer to raptor2

[Artem Serebriyskiy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101741/
-----------------------------------------------------------

(Updated June 24, 2011, 11:09 a.m.)


Review request for Nepomuk and Soprano.


Changes
-------

Ok, I have incorporated all changes to raptor parser,serializer and CMake into one big diff. This patch embedes 'Smit Shah'patch to parser and no, I have no idea how to separate them back :)
As result of this patch parsertest and serializer test pass successfully. But onto2vocabulary still fail. And no, there is no way to separate patch-to-make-serializer-works and patch-to-make-parser-almost-work from each other. For working serializertest you need at least almost working parser.
Also, Smit Shah shoud add his copyrigths to raptorparser.[cpp|h], which I can't do because I have no idea what is his real name and email.


Summary
-------

Port Raptor serializer to libraptor2 + provide test for serializers


Diffs (updated)
-----

  backends/redland/redlandqueryresult.cpp dbddcba 
  cmake/modules/FindRaptor.cmake 6347647 
  parsers/raptor/CMakeLists.txt 2adf527 
  parsers/raptor/raptor-config.h.cmake dc35028 
  parsers/raptor/raptorparser.h e6a7f99 
  parsers/raptor/raptorparser.cpp 0aabb73 
  serializers/raptor/raptorserializer.h 39037bb 
  serializers/raptor/raptorserializer.cpp 959f80a 
  test/CMakeLists.txt a17805a 
  test/serializetest.h PRE-CREATION 
  test/serializetest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101741/diff


Testing
-------

There were no tests in soprano for serializers. So I wrote one( based on parsertest). This, unfortunately, means that it is not possible to rely on this test to detect if port to raptor2 is correct.
Nevertheless, evrything is compiling on my system and this new test is successfully passed.


Thanks,

Artem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110624/40baa9e0/attachment.htm