[Nepomuk] Re: Review Request: Port raptor serializer to raptor2

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101741/#review4116
-----------------------------------------------------------



test/serializetest.h
<http://git.reviewboard.kde.org/r/101741/#comment3367>

    nitpicking: space.



test/serializetest.h
<http://git.reviewboard.kde.org/r/101741/#comment3370>

    what about you?



test/serializetest.h
<http://git.reviewboard.kde.org/r/101741/#comment3368>

    nitpicking: space.



test/serializetest.h
<http://git.reviewboard.kde.org/r/101741/#comment3369>

    nitpicking: unused code is not really needed.



test/serializetest.cpp
<http://git.reviewboard.kde.org/r/101741/#comment3371>

    what about you?



test/serializetest.cpp
<http://git.reviewboard.kde.org/r/101741/#comment3374>

    please remove unused code.



test/serializetest.cpp
<http://git.reviewboard.kde.org/r/101741/#comment3372>

    nitpicking: space.



test/serializetest.cpp
<http://git.reviewboard.kde.org/r/101741/#comment3373>

    nitpicking: space.



test/serializetest.cpp
<http://git.reviewboard.kde.org/r/101741/#comment3375>

    please remove unused code


- Sebastian


On June 23, 2011, 2:43 p.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101741/
> -----------------------------------------------------------
> 
> (Updated June 23, 2011, 2:43 p.m.)
> 
> 
> Review request for Nepomuk and Soprano.
> 
> 
> Summary
> -------
> 
> Port Raptor serializer to libraptor2 + provide test for serializers
> 
> 
> Diffs
> -----
> 
>   test/serializetest.h PRE-CREATION 
>   test/serializetest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101741/diff
> 
> 
> Testing
> -------
> 
> There were no tests in soprano for serializers. So I wrote one( based on parsertest). This, unfortunately, means that it is not possible to rely on this test to detect if port to raptor2 is correct.
> Nevertheless, evrything is compiling on my system and this new test is successfully passed.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110624/2bc764f2/attachment.htm