[Nepomuk] Re: Review Request: Allow deletion of multiple tags without moving the mouse

[Vishesh Handa]

> On July 28, 2011, 4:52 p.m., Peter Penz wrote:
> > nepomuk/ui/kedittagsdialog.cpp, line 261
> > <http://git.reviewboard.kde.org/r/102111/diff/1/?file=30217#file30217line261>
> >
> >     Could be simplified to:
> >     const bool check = m_tag.contains(tag);

Ah! The curse of being verbose. I'll fix it.

This isn't really related to the problem, btw. I just land up cleaning up code as I read through it.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102111/#review5188
-----------------------------------------------------------


On July 28, 2011, 5:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102111/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 5:01 p.m.)
> 
> 
> Review request for Nepomuk, Peter Penz and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Please just read the bug report.
> 
> 
> This addresses bug 248689.
>     http://bugs.kde.org/show_bug.cgi?id=248689
> 
> 
> Diffs
> -----
> 
>   nepomuk/ui/kedittagsdialog.cpp 91fea1b 
> 
> Diff: http://git.reviewboard.kde.org/r/102111/diff
> 
> 
> Testing
> -------
> 
> Dolphin no longer crashes.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110728/dd5624f2/attachment-0001.htm