[Nepomuk] Re: Review Request: Allow deletion of multiple tags without moving the mouse

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102111/#review5188
-----------------------------------------------------------


Thanks for the patch! To me it is fine if this gets pushed but I'd feel more comfortable if Sebastian gives the final "Ship It".


nepomuk/ui/kedittagsdialog.cpp
<http://git.reviewboard.kde.org/r/102111/#comment4683>

    Could be simplified to:
    const bool check = m_tag.contains(tag);


- Peter


On July 28, 2011, 2:40 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102111/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 2:40 p.m.)
> 
> 
> Review request for Nepomuk, Peter Penz and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Please just read the bug report.
> 
> 
> This addresses bug 248689.
>     http://bugs.kde.org/show_bug.cgi?id=248689
> 
> 
> Diffs
> -----
> 
>   nepomuk/ui/kedittagsdialog.cpp 91fea1b 
> 
> Diff: http://git.reviewboard.kde.org/r/102111/diff
> 
> 
> Testing
> -------
> 
> Dolphin no longer crashes.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110728/3a842fc6/attachment.htm