[Nepomuk] Re: Review Request: WritebackJob draft

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102094/#review5171
-----------------------------------------------------------



nepomuk/services/writeback/service/writebackjob.h
<http://git.reviewboard.kde.org/r/102094/#comment4660>

    Here you need full namespacing, too. The reason is that Qt does signal/slot connections via string (char*) matching. Thus, as far as Qt is concerned "Nepomuk::WritebackPlugin*" != "WritebackPlugin*".
    Of course the compiler would not care, it simply needs to find the class. But signals/slots are not handled by the compiler. It is an extension which is converted to proper C++ code by "moc", the "Meta Object Compiler" which is run before gcc and creates these *.moc files you typically include at the end of a source file.



nepomuk/services/writeback/service/writebackservice.h
<http://git.reviewboard.kde.org/r/102094/#comment4661>

    There is no reason to make this public. Also normally we use const references to lists.


- Sebastian


On July 28, 2011, 9:49 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102094/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 9:49 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This is my first attempt to write the writebackjob for the writebackservice.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/writeback/lib/writebackplugin.h 6bcdfd3 
>   nepomuk/services/writeback/lib/writebackplugin.cpp 2a52a31 
>   nepomuk/services/writeback/service/CMakeLists.txt 949b379 
>   nepomuk/services/writeback/service/writebackjob.h e69de29 
>   nepomuk/services/writeback/service/writebackjob.cpp e69de29 
>   nepomuk/services/writeback/service/writebackservice.h a9821a6 
>   nepomuk/services/writeback/service/writebackservice.cpp be5c738 
> 
> Diff: http://git.reviewboard.kde.org/r/102094/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110728/a91c2012/attachment-0001.htm