<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102094/">http://git.reviewboard.kde.org/r/102094/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102094/diff/6/?file=30160#file30160line45" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/services/writeback/service/writebackjob.h</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">slotWritebackFinished</span><span class="p">(</span><span class="n">WritebackPlugin</span><span class="o">*</span> <span class="n">plugin</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here you need full namespacing, too. The reason is that Qt does signal/slot connections via string (char*) matching. Thus, as far as Qt is concerned "Nepomuk::WritebackPlugin*" != "WritebackPlugin*".
Of course the compiler would not care, it simply needs to find the class. But signals/slots are not handled by the compiler. It is an extension which is converted to proper C++ code by "moc", the "Meta Object Compiler" which is run before gcc and creates these *.moc files you typically include at the end of a source file.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102094/diff/6/?file=30162#file30162line41" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/services/writeback/service/writebackservice.h</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">finishWriteback</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">performWriteback</span><span class="p">(</span><span class="n">KService</span><span class="o">::</span><span class="n">List</span> <span class="n">services</span><span class="p">,</span><span class="k">const</span> <span class="n">Nepomuk</span><span class="o">::</span><span class="n">Resource</span> <span class="o">&</span> <span class="n">resource</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no reason to make this public. Also normally we use const references to lists.</pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On July 28th, 2011, 9:49 a.m., Smit Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Smit Shah.</div>
<p style="color: grey;"><i>Updated July 28, 2011, 9:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my first attempt to write the writebackjob for the writebackservice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/services/writeback/lib/writebackplugin.h <span style="color: grey">(6bcdfd3)</span></li>
<li>nepomuk/services/writeback/lib/writebackplugin.cpp <span style="color: grey">(2a52a31)</span></li>
<li>nepomuk/services/writeback/service/CMakeLists.txt <span style="color: grey">(949b379)</span></li>
<li>nepomuk/services/writeback/service/writebackjob.h <span style="color: grey">(e69de29)</span></li>
<li>nepomuk/services/writeback/service/writebackjob.cpp <span style="color: grey">(e69de29)</span></li>
<li>nepomuk/services/writeback/service/writebackservice.h <span style="color: grey">(a9821a6)</span></li>
<li>nepomuk/services/writeback/service/writebackservice.cpp <span style="color: grey">(be5c738)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102094/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>