[Nepomuk] Review Request: Added the ability to see currently indexed file and ability to pause or resume strigi in status widget

[Sebastian Trueg]

> On Aug. 19, 2011, 11:27 a.m., Sebastian Trueg wrote:
> > nepomuk/kcm/CMakeLists.txt, line 19
> > <http://git.reviewboard.kde.org/r/102301/diff/5/?file=32032#file32032line19>
> >
> >     Why this change?
> 
> Smit Shah wrote:
>      Well in controller this was named as servicecontrol and here the exact same thing was named as nepomukservicecontrolinterface , i thought since both do the same thing its better to have the same name.
> 
> Sebastian Trueg wrote:
>     I see. No matter really. And since it is not related to this patch please revert it. It only confuses people looking at the patch.
> 
> Smit Shah wrote:
>     Okay one minor thing , since in controller cmakelist we are linking with statuswidget.cpp , i.e 
>     
>     set(controller_SRCS
>       main.cpp
>       systray.cpp
>       ../kcm/statuswidget.cpp
>       )
>     
>     we do need a common name in both of them , otherwise it failed to find the particular header file (i.e. if we name nepomukservicecontrolinterface.h in kcm , it will compile successfully but when compiling controller it will fail to find the particular file as it will be looking for servicecontrol.h)

Right. I did not think of that. Good work.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102301/#review5824
-----------------------------------------------------------


On Aug. 20, 2011, 7:23 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102301/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2011, 7:23 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Now you can pause or resume strigi and see the currently indexed file.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/statuswidget.ui 359ec6e 
>   nepomuk/controller/systray.cpp 6cf6bc9 
>   nepomuk/kcm/CMakeLists.txt 561d48a 
>   nepomuk/kcm/nepomukserverkcm.cpp 74031b7 
>   nepomuk/kcm/statuswidget.h 0440745 
>   nepomuk/kcm/statuswidget.cpp 4798d7f 
> 
> Diff: http://git.reviewboard.kde.org/r/102301/diff
> 
> 
> Testing
> -------
> 
> paused and resume couple of times and it works perfectly.
> 
> 
> Screenshots
> -----------
> 
> See
>   http://git.reviewboard.kde.org/r/102301/s/223/
> see again
>   http://git.reviewboard.kde.org/r/102301/s/224/
> with current status
>   http://git.reviewboard.kde.org/r/102301/s/226/
> 
>   http://git.reviewboard.kde.org/r/102301/s/227/
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110820/71924cd2/attachment.html>