<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102301/">http://git.reviewboard.kde.org/r/102301/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2011, 11:27 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102301/diff/5/?file=32032#file32032line19" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/kcm/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">qt4_add_dbus_interface(kcmnepomuk_SRCS ../interfaces/org.kde.nepomuk.ServiceControl.xml <span class="hl">nepomuk</span>servicecontrol<span class="hl">interface</span>)</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">qt4_add_dbus_interface(kcmnepomuk_SRCS ../interfaces/org.kde.nepomuk.ServiceControl.xml servicecontrol)</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why this change?</pre>
</blockquote>
<p>On August 20th, 2011, 7 a.m., <b>Smit Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Well in controller this was named as servicecontrol and here the exact same thing was named as nepomukservicecontrolinterface , i thought since both do the same thing its better to have the same name.</pre>
</blockquote>
<p>On August 20th, 2011, 9:06 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see. No matter really. And since it is not related to this patch please revert it. It only confuses people looking at the patch.</pre>
</blockquote>
<p>On August 20th, 2011, 10:43 a.m., <b>Smit Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay one minor thing , since in controller cmakelist we are linking with statuswidget.cpp , i.e
set(controller_SRCS
main.cpp
systray.cpp
../kcm/statuswidget.cpp
)
we do need a common name in both of them , otherwise it failed to find the particular header file (i.e. if we name nepomukservicecontrolinterface.h in kcm , it will compile successfully but when compiling controller it will fail to find the particular file as it will be looking for servicecontrol.h) </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right. I did not think of that. Good work.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On August 20th, 2011, 7:23 a.m., Smit Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Smit Shah.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2011, 7:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now you can pause or resume strigi and see the currently indexed file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">paused and resume couple of times and it works perfectly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/statuswidget.ui <span style="color: grey">(359ec6e)</span></li>
<li>nepomuk/controller/systray.cpp <span style="color: grey">(6cf6bc9)</span></li>
<li>nepomuk/kcm/CMakeLists.txt <span style="color: grey">(561d48a)</span></li>
<li>nepomuk/kcm/nepomukserverkcm.cpp <span style="color: grey">(74031b7)</span></li>
<li>nepomuk/kcm/statuswidget.h <span style="color: grey">(0440745)</span></li>
<li>nepomuk/kcm/statuswidget.cpp <span style="color: grey">(4798d7f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102301/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102301/s/223/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/11/snapshot2_400x100.png" style="border: 1px black solid;" alt="See" /></a>
<a href="http://git.reviewboard.kde.org/r/102301/s/224/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/11/snapshot3_400x100.png" style="border: 1px black solid;" alt="see again" /></a>
<a href="http://git.reviewboard.kde.org/r/102301/s/226/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/12/snapshot1_400x100.png" style="border: 1px black solid;" alt="with current status" /></a>
<a href="http://git.reviewboard.kde.org/r/102301/s/227/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/12/snapshot4_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>