[Nepomuk] Review Request: Add nfo:Audio type to riff analyzer

Vishesh Handa handa.vish at gmail.com
Tue Aug 16 16:45:48 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102336/
-----------------------------------------------------------

(Updated Aug. 16, 2011, 4:45 p.m.)


Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.


Changes
-------

Add nfo:Audio if it is an audio stream, nfo:Video otherwise.


Summary
-------

Add the required type. I'm not sure if I should be adding nfo:Audio or nfo:MusicPiece.


Diffs (updated)
-----

  lib/endanalyzers/id3endanalyzer.cpp 5060e1b 
  plugins/eventplugins/riffeventanalyzer.cpp 69aa927 

Diff: http://git.reviewboard.kde.org/r/102336/diff


Testing
-------

Works fine, and the files are getting indexed by Nepomuk as they have the correct type.


Thanks,

Vishesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110816/3707454d/attachment.html>


More information about the Nepomuk mailing list