[Nepomuk] Review Request: Add nfo:Audio type to riff analyzer
Sebastian Trueg
sebastian at trueg.de
Tue Aug 16 13:24:28 UTC 2011
> On Aug. 16, 2011, 12:49 p.m., Sebastian Trueg wrote:
> > Code looks good to me. But does the riff analyser only handle audio or also video files?
>
> Vishesh Handa wrote:
> It can apparently handle both -
>
> http://www.digitalpreservation.gov/formats/fdd/fdd000025.shtml
> http://en.wikipedia.org/wiki/Resource_Interchange_File_Format
>
> It's used in AVI files as well. What should I do? Add nfo:Video as well? That seems kinda wrong. Maybe the riff analyzer shouldn't be adding any type, and the types should be added by another analyzer.
>
>
The analyzer has a member var "isAudioStream" which seems to be true only for, well, audio streams. Maybe that could be used.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102336/#review5738
-----------------------------------------------------------
On Aug. 16, 2011, 9:19 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102336/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2011, 9:19 a.m.)
>
>
> Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.
>
>
> Summary
> -------
>
> Add the required type. I'm not sure if I should be adding nfo:Audio or nfo:MusicPiece.
>
>
> Diffs
> -----
>
> plugins/eventplugins/riffeventanalyzer.cpp 69aa927
>
> Diff: http://git.reviewboard.kde.org/r/102336/diff
>
>
> Testing
> -------
>
> Works fine, and the files are getting indexed by Nepomuk as they have the correct type.
>
>
> Thanks,
>
> Vishesh
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110816/df541c5d/attachment-0001.html>
More information about the Nepomuk
mailing list