[Nepomuk] Review Request: Do not update the whole containing folder when a file changes

Sebastian Trueg sebastian at trueg.de
Wed Aug 10 14:02:52 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102197/
-----------------------------------------------------------

(Updated Aug. 10, 2011, 2:02 p.m.)


Review request for Nepomuk.


Changes
-------

Updated the patch to be based on git master.


Summary
-------

So far when a file changes on disk or is newly created the file watch service would tell the file indexer to update the containing folder. For large folders this is a big waste of resources. With this patch the indexFile method of the file indexer makes use of the filesToIndexQueue in the IndexScheduler. By prepending it to the queue we ensure that newly created and changed files always come before the initial indexing. This is what the user expects.


Diffs (updated)
-----

  nepomuk/services/filewatch/nepomukfilewatch.h 5a1b2cb 
  nepomuk/services/filewatch/nepomukfilewatch.cpp aeb3d7b 
  nepomuk/services/strigi/indexscheduler.h da9a923 
  nepomuk/services/strigi/indexscheduler.cpp 94f8644 

Diff: http://git.reviewboard.kde.org/r/102197/diff


Testing
-------


Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110810/0879b590/attachment.html>


More information about the Nepomuk mailing list