[Nepomuk] Review Request: Do not update the whole containing folder when a file changes

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102197/#review5498
-----------------------------------------------------------


Uhm. I seem to have introduced a lot of mutexes in the IndexScheduler. Could you maybe look at that patch first?

( And maybe this patch should only fix the indexing of one file, instead of fixing threading as well )

- Vishesh


On Aug. 4, 2011, 2:39 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102197/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2011, 2:39 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> So far when a file changes on disk or is newly created the file watch service would tell the file indexer to update the containing folder. For large folders this is a big waste of resources. With this patch the indexFile method of the file indexer makes use of the filesToIndexQueue in the IndexScheduler. By prepending it to the queue we ensure that newly created and changed files always come before the initial indexing. This is what the user expects.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/filewatch/nepomukfilewatch.h 5a1b2cb 
>   nepomuk/services/filewatch/nepomukfilewatch.cpp aeb3d7b 
>   nepomuk/services/strigi/indexscheduler.h 4c83d04 
>   nepomuk/services/strigi/indexscheduler.cpp 9e83a89 
> 
> Diff: http://git.reviewboard.kde.org/r/102197/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110808/a99bf4a2/attachment.html>