[Nepomuk] Review Request: Instead of passing plugins, we pass services to writebackjob

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102232/#review5432
-----------------------------------------------------------


I cannot remember why we wanted to do this in the first place but now it does not make any sense anymore. Think about this a bit: you always only create the one job directly before starting it. This does not save any memory anymore. It would only make sense if you queued the jobs instead of the resources. But that is of no use unless you act on more detail than the resource itself.

- Sebastian


On Aug. 6, 2011, 12:51 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102232/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2011, 12:51 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Instead of passing plugins which occupy more memory , we pass services and create the instance in writebackjob.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/writeback/service/writebackjob.h 612931f 
>   nepomuk/services/writeback/service/writebackjob.cpp f7b5abb 
>   nepomuk/services/writeback/service/writebackservice.h db6e83a 
>   nepomuk/services/writeback/service/writebackservice.cpp 673aa59 
> 
> Diff: http://git.reviewboard.kde.org/r/102232/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110806/cd9258ac/attachment.html>