[Nepomuk] Re: Review Request: Auto Indent Queries

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101103/#review2628
-----------------------------------------------------------

Ship it!


I say for now: ship it. There are still quirks to work out but for a first version it is good and useful. One funny thing: try calling the action multiple times in a row. You end up with a lot of useless newlines. This is because the algorithm does not take existing newlines into account. You could just call QString::simplified() on the query beforehand but that would also change spaces in literals which is not perfect.

- Sebastian


On April 14, 2011, 5:09 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101103/
> -----------------------------------------------------------
> 
> (Updated April 14, 2011, 5:09 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This patch adds one feature,
> 
>  Adds a button to auto indent the query.
> 
> 
> Diffs
> -----
> 
>   mainwindow.h ebf4dd5 
>   mainwindow.cpp d9cd450 
>   nepomukshellui.rc e4d59c2 
>   resourcequerywidget.h 22224fc 
>   resourcequerywidget.cpp 757674f 
> 
> Diff: http://git.reviewboard.kde.org/r/101103/diff
> 
> 
> Testing
> -------
> 
> i have tested both the features on number of queries/files and it works perfectly over here.
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110414/6244bddc/attachment.htm