<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101103/">http://git.reviewboard.kde.org/r/101103/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I say for now: ship it. There are still quirks to work out but for a first version it is good and useful. One funny thing: try calling the action multiple times in a row. You end up with a lot of useless newlines. This is because the algorithm does not take existing newlines into account. You could just call QString::simplified() on the query beforehand but that would also change spaces in literals which is not perfect.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On April 14th, 2011, 5:09 a.m., Smit Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Smit Shah.</div>
<p style="color: grey;"><i>Updated April 14, 2011, 5:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds one feature,
Adds a button to auto indent the query.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i have tested both the features on number of queries/files and it works perfectly over here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.h <span style="color: grey">(ebf4dd5)</span></li>
<li>mainwindow.cpp <span style="color: grey">(d9cd450)</span></li>
<li>nepomukshellui.rc <span style="color: grey">(e4d59c2)</span></li>
<li>resourcequerywidget.h <span style="color: grey">(22224fc)</span></li>
<li>resourcequerywidget.cpp <span style="color: grey">(757674f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101103/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>