[Nepomuk] [patch] playground/nepomukutils/searchmenu.cpp

[Sebastian Trüg]

Hi Oszkar,

As for your question: I would say simply disconnect each time and only
reconnect if SearchWhileYouType is enabled. The config will not be
changed that often so there is no overhead problem.
Also please remove the AllFlags enum entry. It does not make much sense
here.

Apart from that: please commit. :)

Cheers,
Sebastian

On 05/31/2010 05:58 PM, Oszkar Ambrus wrote:
> On 31 May 2010 15:39, Sebastian Trüg <trueg at kde.org> wrote:
>> It does make sense but certainly not as a default. So it would have to
>> be configurable. As with AnnotationMenu I would prefer configuration
>> flags over boolean parameters.
> 
> Done.
> 
> There still was one problem (that had been a problem before these
> changes were made): the LineEdit connections were never made for the
> default case, as the condition always evaluates to false (since we set
> NoFlags, which equals the default value that has already been set).
> The solutions I saw are these two (from which I chose the second one):
> 1. We make the initial connections in the constructor (this results in
> code duplication),
> 2. We set AllFlags as the default value for the flags first (in the
> Private constructor), then set NoFlags.
> Is there a better solution?
> 
> Cheers,
> Oszkar