[Nepomuk] [patch] playground/nepomukutils/searchmenu.cpp

[Oszkar Ambrus]

On 31 May 2010 15:39, Sebastian Trüg <trueg at kde.org> wrote:
> It does make sense but certainly not as a default. So it would have to
> be configurable. As with AnnotationMenu I would prefer configuration
> flags over boolean parameters.

Done.

There still was one problem (that had been a problem before these
changes were made): the LineEdit connections were never made for the
default case, as the condition always evaluates to false (since we set
NoFlags, which equals the default value that has already been set).
The solutions I saw are these two (from which I chose the second one):
1. We make the initial connections in the constructor (this results in
code duplication),
2. We set AllFlags as the default value for the flags first (in the
Private constructor), then set NoFlags.
Is there a better solution?

Cheers,
Oszkar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: annotation.diff
Type: text/x-patch
Size: 627 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20100531/3777b653/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nepomukutils.diff
Type: text/x-patch
Size: 3381 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20100531/3777b653/attachment-0001.diff