[Nepomuk] Request for comments on new Nepomuk API

[Vishesh Handa]

Yup.

You don't really need to explicitly check if m_data is not NULL, but it's
okay if you are. m_data will always have some value.

On Thu, Aug 5, 2010 at 7:53 PM, Sebastian Trüg <trueg at kde.org> wrote:

> On 08/05/2010 04:05 PM, Vishesh Handa wrote:
> > I like it, but it won't work.
> >
> > Due to the messy internals of Nepomuk::Resource, you'll have to
> > call *determineFinalResourceData() *before calling
> > ResourceData::isFile() in Resource. If you don't do that then you'll get
> > code like this -
> >
> > Resource r1("nepomuk:/res/res-uuid");
> > r1.isFile(); // will always says false even though the resource might be
> > a file
> > r1.rating(); // determineUri has now been called internally
> > r1.isFile(); // now it will return true if the resource is a file
> >
> > If you want I could write a patch. I may be wrong, I haven't looked at
> > the patch that carefully.
>
> You are right. This is why I posted the patch. Thanks for noticing. I
> suppose something like the following would be enough:
>
> isFile()
> {
> if(m_data){
> determineFinalResourceData();
> return m_data->isFile();
> }
> else...
>
> CHeers,
> Sebastian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20100805/dd37dd5c/attachment.htm